<html>
<head><meta charset="utf-8"><title>Review PR #70193? · t-lang · Zulip Chat Archive</title></head>
<h2>Stream: <a href="https://rust-lang.github.io/zulip_archive/stream/213817-t-lang/index.html">t-lang</a></h2>
<h3>Topic: <a href="https://rust-lang.github.io/zulip_archive/stream/213817-t-lang/topic/Review.20PR.20.2370193.3F.html">Review PR #70193?</a></h3>

<hr>

<base href="https://rust-lang.zulipchat.com">

<head><link href="https://rust-lang.github.io/zulip_archive/style.css" rel="stylesheet"></head>

<a name="196986505"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/213817-t-lang/topic/Review%20PR%20%2370193%3F/near/196986505" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> RalfJ <a href="https://rust-lang.github.io/zulip_archive/stream/213817-t-lang/topic/Review.20PR.20.2370193.3F.html#196986505">(May 09 2020 at 11:15)</a>:</h4>
<p>Can someone review <a href="https://github.com/rust-lang/rust/issues/70193" title="https://github.com/rust-lang/rust/issues/70193">#70193</a> (Limit maximum alignment in #[repr(align)] to 4K)? It keeps getting bounced from reviewer to reviewer and somehow ended up on my list...</p>



<a name="196986558"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/213817-t-lang/topic/Review%20PR%20%2370193%3F/near/196986558" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> RalfJ <a href="https://rust-lang.github.io/zulip_archive/stream/213817-t-lang/topic/Review.20PR.20.2370193.3F.html#196986558">(May 09 2020 at 11:16)</a>:</h4>
<p><span class="user-mention" data-user-id="143274">@Amanieu</span> says that</p>
<blockquote>
<p>I believe the latest consensus is that we should emit a warning, with the intention of changing it to a hard error later.</p>
</blockquote>
<p>Is that decision documented somewhere? The last I saw is <span class="user-mention" data-user-id="116009">@nikomatsakis</span> asking some questions.</p>



<a name="196986587"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/213817-t-lang/topic/Review%20PR%20%2370193%3F/near/196986587" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Amanieu <a href="https://rust-lang.github.io/zulip_archive/stream/213817-t-lang/topic/Review.20PR.20.2370193.3F.html#196986587">(May 09 2020 at 11:17)</a>:</h4>
<p>I believe it was discussed in the lang team meeting.</p>



<a name="196986725"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/213817-t-lang/topic/Review%20PR%20%2370193%3F/near/196986725" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> DPC <a href="https://rust-lang.github.io/zulip_archive/stream/213817-t-lang/topic/Review.20PR.20.2370193.3F.html#196986725">(May 09 2020 at 11:20)</a>:</h4>
<p>I guess I could reassign it to Niko for the moment. Sorry for the "reviewer juggling" <span aria-label="sweat smile" class="emoji emoji-1f605" role="img" title="sweat smile">:sweat_smile:</span></p>



<a name="197011230"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/213817-t-lang/topic/Review%20PR%20%2370193%3F/near/197011230" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Josh Triplett <a href="https://rust-lang.github.io/zulip_archive/stream/213817-t-lang/topic/Review.20PR.20.2370193.3F.html#197011230">(May 09 2020 at 20:28)</a>:</h4>
<p>I can confirm that that was the decision. We did, however, want the limit to come from the target definition, so that targets can easily define a larger limit.</p>



<hr><p>Last updated: Aug 07 2021 at 22:04 UTC</p>
</html>